8000 [Form] Fix form value merging involving file upload, collection & checkbox by priyadi · Pull Request #54324 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Fix form value merging involving file upload, collection & checkbox #54324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: 5.4
Choose a base branch
from
Open

[Form] Fix form value merging involving file upload, collection & checkbox #54324

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
597b6a3
add failed test for partial data submitting with collections
Jan 2, 2024
f943adb
refactor param & files merging
priyadi Mar 18, 2024
fdc3e01
cs fix
priyadi Mar 18, 2024
79fdbaa
type hints, etc
priyadi Mar 19, 2024
0c9b3d7
simplify
priyadi Mar 19, 2024
f3b5efd
cs
priyadi Mar 19, 2024
55deed0
apply all suggestions
priyadi Mar 24, 2024
aec4b56
cs
priyadi Mar 24, 2024
21fbb71
revert typehint removal
priyadi Mar 24, 2024
60008f4
remove unneeded @params
priyadi Mar 24, 2024
30c95b8
assorted changes
priyadi Mar 24, 2024
ac24610
inline ParamFilesMerger methods
xabbuh May 15, 2024
1cf2c5f
cs fix
priyadi May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert typehint removal
  • Loading branch information
@priyadi
priyadi committed Mar 24, 2024
commit 21fbb71daf2a59fb7980606e9e7f4636ceb210db
2 changes: 2 additions & 0 deletions src/Symfony/Component/Form/Util/FormUtil.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,8 @@ private function __construct()
* a form and needs to be consistent. PHP keyword `empty` cannot
* be used as it also considers 0 and "0" to be empty.
*
* @param mixed $data
*
* @return bool
*/
public static function isEmpty($data)
Expand Down
0