8000 Missing translations for Greek (el) #53768 by dev-george-nikolaidis · Pull Request #54209 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Missing translations for Greek (el) #53768 #54209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2024
Merged

Missing translations for Greek (el) #53768 #54209

merged 1 commit into from
Mar 12, 2024

Conversation

dev-george-nikolaidis
Copy link
Contributor

Branch 5.4,
Bug fixes no

I've addressed missing Greek translations in issue #53768. This pull request includes the necessary changes.
Changes:

Added Greek (el) translations for missing strings.

Kindly review and merge if satisfactory.

@carsonbot carsonbot added this to the 7.1 milestone Mar 8, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@nicolas-grekas nicolas-grekas modified the milestones: 7.1, 5.4 Mar 12, 2024
@nicolas-grekas nicolas-grekas changed the base branch from 7.1 to 5.4 March 12, 2024 12:25
@nicolas-grekas
Copy link
Member

Thank you @dev-george-nikolaidis.

@nicolas-grekas nicolas-grekas merged commit 9fe7efc into symfony:5.4 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@dev-george-nikolaidis @carsonbot @nicolas-grekas
0