8000 [Mailer] [Brevo] Remove tags from mandatory event arguments by palgalik · Pull Request #54089 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mailer] [Brevo] Remove tags from mandatory event arguments #54089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 28, 2024
Merged

[Mailer] [Brevo] Remove tags from mandatory event arguments #54089

merged 1 commit into from
Feb 28, 2024

Conversation

palgalik
Copy link
Contributor
@palgalik palgalik commented Feb 27, 2024 •
edited
Loading

'tags' in not mandatory part of an event
therefore it got removed from the validation process

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix 54088
License MIT

8000
@palgalik
[Mailer][Brevo] Remove tags from mandatory event arguments
dfb41cd 
'tags' in not mandatory part of an event
therefore it got removed from the validation process
@carsonbot carsonbot added this to the 7.1 milestone Feb 27, 2024
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [Mailer][Brevo] Remove tags from mandatory event arguments [Mailer] [Brevo] Remove tags from mandatory event arguments Feb 27, 2024
@palgalik palgalik changed the base branch from 7.1 to 6.4 February 27, 2024 17:03
@palgalik palgalik changed the base branch from 6.4 to 6.3 February 27, 2024 19:44
@palgalik palgalik changed the base branch from 6.3 to 6.4 February 27, 2024 19:44
@symfony symfony deleted a comment from carsonbot Feb 28, 2024
@fabpot fabpot modified the milestones: 7.1, 6.4 Feb 28, 2024
@fabpot
Copy link
Member
fabpot commented Feb 28, 2024

Thank you @palgalik.

@fabpot fabpot merged commit 182e93e into symfony:6.4 Feb 28, 2024
This was referenced Mar 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@kbond kbond Awaiting requested review from kbond

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@OskarStark OskarStark Awaiting requested review from OskarStark

@jderusse jderusse Awaiting requested review from jderusse

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Mailer Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@palgalik @carsonbot @fabpot
0