10000 [Messenger] Gracefully fallback to empty queue config by Wirone · Pull Request #53944 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Messenger] Gracefully fallback to empty queue config #53944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2024
Merged

[Messenger] Gracefully fallback to empty queue config #53944

merged 1 commit into from
Feb 14, 2024

Conversation

Wirone
Copy link
Contributor
@Wirone Wirone commented Feb 14, 2024 •
edited by nicolas-grekas
Loading
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fixes #53579
License MIT

Do not produce notice/warning when consuming from multiple transports and explicitly listed queues.

These queues might not be present on each consumed transport.

@carsonbot carsonbot added this to the 6.4 milestone Feb 14, 2024
@carsonbot
Copy link
carsonbot 8000 commented Feb 14, 2024

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 and probably newer".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@Wirone
Copy link
Contributor Author
Wirone commented Feb 14, 2024 •
edited
Loading

@sroze @nicolas-grekas I don't know how to test this change, since currently queue() is not tested anyway (or I don't see it). As described in #53944 this is rather safe and straightforward fix, since all the $queueConfig usages after fetching $this->queuesOptions[$queueName] are null-safe ($queueConfig['flags'] ?? \AMQP_DURABLE, if(isset($queueConfig['arguments'])).

This change fixes our future problem because we have custom error handler which throws exceptions on such warnings, and currently we can't properly run workers based on Messenger because it would fail on this warning. We're on PoC stage, using Symfony's error handler in bin/console but before going fully with new consumer approach we need to introduce our custom error handler there, so errors in CLI are reported properly as in other places of the app. So this little change is a blocker for us 😅.

PS. CI failures seem to be unrelated?

@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 5.4 Feb 14, 2024
@Wirone @nicolas-grekas
Do not produce notice/warning when consuming from multiple transports…
9d67850 
… and explicitly listed queues

These queues might not be present on each consumed transport.
@nicolas-grekas nicolas-grekas changed the base branch from 6.4 to 5.4 February 14, 2024 16:15
@nicolas-grekas
Copy link
Member

Thank you @Wirone.

@nicolas-grekas nicolas-grekas merged commit f44d074 into symfony:5.4 Feb 14, 2024
@Wirone Wirone deleted the codito/fix-53579 branch February 14, 2024 16:35
This was referenced Feb 27, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@chalasr chalasr Awaiting requested review from chalasr

@dunglas dunglas Awaiting requested review from dunglas

@OskarStark OskarStark Awaiting requested review from OskarStark

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Messenger Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Wirone @carsonbot @nicolas-grekas
0