8000 [Validator] Missing translations for Estonian (et) by bifidokk · Pull Request #53848 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[Validator] Missing translations for Estonian (et) #53848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

bifidokk
Copy link
Contributor
@bifidokk bifidokk commented Feb 7, 2024
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #53766
License MIT

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely. Thank you!

@nicolas-grekas nicolas-grekas changed the title [Validator] Missing translations for Estonian (et) #53766 [Validator] Missing translations for Estonian (et) Feb 8, 2024
@nicolas-grekas nicolas-grekas force-pushed the 5.4-update-et-translations branch from a1122aa to 0c4d271 Compare February 8, 2024 15:45
@nicolas-grekas
Copy link
Member

Thank you @bifidokk.

@nicolas-grekas nicolas-grekas merged commit 94de76d into symfony:5.4 Feb 8, 2024
@bifidokk bifidokk deleted the 5.4-update-et-translations branch February 8, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0