8000 Fix Inconsistent Exit Status in `proc_get_status` for PHP Versions Below 8.3 by Luc45 · Pull Request #53820 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix Inconsistent Exit Status in proc_get_status for PHP Versions Below 8.3 #53820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Fix Inconsistent Exit Status in proc_get_status for PHP Versions Below 8.3 #53820

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
400e5d9
Cache exitcode on PHP 8.2 and lower
Luc45 Feb 7, 2024
7e8b115
Update comment
Luc45 Feb 7, 2024
b608345
Typo
Luc45 Feb 7, 2024
8b376d3
Code style
Luc45 Feb 7, 2024
93cbc4b
Code style
Luc45 Feb 7, 2024
1129b64
Code style
Luc45 Feb 7, 2024
144796f
Code style
Luc45 Feb 7, 2024
d7e0aeb
Code style
Luc45 Feb 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Code style
  • Loading branch information
@Luc45
Luc45 authored Feb 7, 2024
commit 8b376d367598d0e96c303d27207b93ddd79931ea
8 changes: 4 additions & 4 deletions src/Symfony/Component/Process/Process.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1292,19 +1292,19 @@ protected function updateStatus(bool $blocking): void

$running = $this->processInformation['running'];

/*
/*
* In PHP < 8.3, "proc_get_status" only returns the correct exit status on the first call.
* Subsequent calls return -1 as the process is discarded. This workaround caches the first
* retrieved exit status for consistent results in later calls, mimicking PHP 8.3 behavior.
*/
if (version_compare(PHP_VERSION, '8.3.0', '<')) {
if (version_compare(\PHP_VERSION, '8.3.0', '<')) {
static $cachedExitCode = null;

if (is_null($cachedExitCode) && !$running && $this->processInformation['exitcode'] !== -1) {
if (null === $cachedExitCode && !$running && $this->processInformation['exitcode'] !== -1) {
$cachedExitCode = $this->processInformation['exitcode'];
}

if (!is_null($cachedExitCode) && !$running && $this->processInformation['exitcode'] === -1) {
if (null !== $cachedExitCode && !$running && $this->processInformation['exitcode'] === -1) {
$this->processInformation['exitcode'] = $cachedExitCode;
}
}
Expand Down
0