[WIP][FrameworkBundle] Added server status command #5373
Conversation
|
When I first read "server status command" I thought of something else. This name is not optimal because a "status" is something that can change over time, e.g. a disruption of service. But the requirements fulfillment usually cannot change randomly without manual changes. So something like "server config check" is more appropriate. |
| * @author Tiago Ribeiro <tiago.ribeiro@seegno.com> | ||
| * @author Rui Marinho <rui.marinho@seegno.com> | ||
| */ | ||
| class ServerStatusCommand extends ContainerAwareCommand |
There was a problem hiding this comment.
No need to extend ContainerAwareCommand when you dont use the container.
|
I like the idea but the problem is that we have the requirements now at 2 places redundant (here and in FrameworkExtraBundle where it is automatically copied to |
|
I was thinking about suggesting the removal of the files from those 2 places if this change is accepted. |
|
I don't think this should be in FrameworkBundle. It is not required to have it to use the framework. SensioDistributionBundle is better for this. And the way you implemented it requires to have s 8000 ymfony up and running before being able to check the requirements (you need to be able to boot the kernel). So I think half of these requirements checks may become useless because they will fail before you can check them. |
|
Closing this PR as I like the way it is done now better. |
This PR was squashed before being merged into the 7.1 branch. Discussion ---------- [Notifier] [SMSense] add docs Add SMSFactor docs symfony/symfony#5373 fixes #19588 Commits ------- 4fc32cd [Notifier] [SMSense] add docs
This pull request is an attempt to move the
check.phpfromsymfony-standardto theFrameworkBundle.Is this something that can be merged in the future? Should we continue the work?