8000 [Mailer] [Mailgun] Fix payload converter getReason by norkunas · Pull Request #53716 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mailer] [Mailgun] Fix payload converter getReason #53716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2024
Merged

[Mailer] [Mailgun] Fix payload converter getReason #53716

merged 1 commit into from
Feb 1, 2024

Conversation

norkunas
Copy link
Contributor
@norkunas norkunas commented Feb 1, 2024
Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Issues N/A
License MIT

Sentry logged in our prod env ErrorException: Warning: Undefined array key "description".

{
    "event-data": {
        "delivery-status": {
            "bounce-code": "5.7.133", 
            "code": 550, 
            "enhanced-code": "5.7.133",
            "message": "[Filtered]"
        }
    }
}

So this means that description is not always set

@carsonbot
Copy link

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 5.4, 6.4, 7.0, 7.1.

Cheers!

Carsonbot

@norkunas
Copy link
Contributor Author
norkunas commented Feb 1, 2024

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/

PR template still shows 6.3 in list that's why I've made against it

@norkunas norkunas force-pushed the fix-mailgun-payload-converter branch from 21fe480 to 85de55b Compare February 1, 2024 08:48
@fabpot fabpot changed the base branch from 6.3 to 6.4 February 1, 2024 09:11
@fabpot fabpot force-pushed the fix-mailgun-payload-converter branch from 85de55b to b960f67 Compare February 1, 2024 09:11
@fabpot
Copy link
Member
fabpot commented Feb 1, 2024

Thank you @norkunas.

@fabpot fabpot merged commit 61794ae into symfony:6.4 Feb 1, 2024
@norkunas norkunas deleted the fix-mailgun-payload-converter branch February 1, 2024 09:12
This was referenced Feb 27, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug Mailer Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norkunas @carsonbot @fabpot
0