8000 [HttpKernel] Fix including welcome page multiple times by HypeMC · Pull Request #53689 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[HttpKernel] Fix including welcome page multiple times #53689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

HypeMC
Copy link
Contributor
@HypeMC HypeMC commented Jan 30, 2024
Q A
Branch? 7.0
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #53686
License MIT

Reverts #53239 & switches to using closures instead.

@HypeMC HypeMC force-pushed the fix-including-welcome-page-multiple-times branch from a99c660 to 4e55227 Compare January 31, 2024 09:25
@nicolas-grekas
Copy link
Member

For 5.4? Why 7.0?

@HypeMC
Copy link
Contributor Author
HypeMC commented Jan 31, 2024

@nicolas-grekas The functions were introduced in 7.0: #51771

@nicolas-grekas
Copy link
Member

Thank you @HypeMC.

@nicolas-grekas nicolas-grekas merged commit ee07003 into symfony:7.0 Jan 31, 2024
@HypeMC HypeMC deleted the fix-including-welcome-page-multiple-times branch January 31, 2024 11:41
@fabpot fabpot mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0