8000 [FrameworkBundle] non-permanent redirect to unknown location with 404 by Tobion · Pull Request #5368 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[FrameworkBundle] non-permanent redirect to unknown location with 404 #5368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2012

Conversation

Tobion
Copy link
Contributor
@Tobion Tobion commented Aug 28, 2012

according to spec: http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html see 410 Gone

bc break: tiny when omitting 2 parameter (I can avoid this with func_num_args but i think its not necessary and makes the code strange and inconsistent)

@travisbot
Copy link

This pull request passes (merged 4c5bfab into c0590bf).

fabpot added a commit that referenced this pull request Aug 29, 2012
Commits
-------

3f8127c fixed '0' problem
7bec460 fixed phpdoc
4c5bfab [FrameworkBundle] non-permanent redirect should be status code 404 according to spec

Discussion
----------

[FrameworkBundle] non-permanent redirect to unknown location with 404

according to spec: http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html see 410 Gone

bc break: tiny when omitting 2 parameter (I can avoid this with `func_num_args` but i think its not necessary and makes the code strange and inconsistent)
@fabpot fabpot merged commit 3f8127c into symfony:master Aug 29, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0