8000 [TwigBridge] separate child and parent context in NotificationEmail on writes by xabbuh · Pull Request #53663 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBridge] separate child and parent context in NotificationEmail on writes #53663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

A 8000 lready on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2024
Merged

[TwigBridge] separate child and parent context in NotificationEmail on writes #53663

merged 1 commit into from
Jan 29, 2024

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Jan 29, 2024
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #53655
License MIT

@carsonbot carsonbot added this to the 5.4 milestone Jan 29, 2024
@xabbuh xabbuh mentioned this pull request Jan 29, 2024
Closed
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 4a124ac into symfony:5.4 Jan 29, 2024
@xabbuh xabbuh deleted the issue-53655 branch January 29, 2024 13:08
@fyrye
Copy link
fyrye commented Jan 29, 2024 •
edited
Loading

Thank you very much. This change seems to make it behave as expected.

Wasn't sure about the intention behind NotificationEmail::$context being immutable outside of method calls like ::markAsPublic() and ::markdown() or not.
eg:

$notification = Notification::asPublicEmail();
$notification->context(['footer_text' => 'Custom Footer Text']);

This was referenced Jan 30, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Status: Needs Review TwigBridge
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @nicolas-grekas @fyrye @carsonbot
0