[Form] replaced UnexpectedValueException by InvalidArgumentException in Guess #5361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in Guess this is a better fit because the error is a logic exception instead of a runtime exception
|
👍 |
fabpot
added a commit
that referenced
this pull request
Aug 29, 2012
Commits ------- e7e39e0 [Form] refactor Guess dcbeeb1 [Form] replaced UnexpectedValueException by InvalidArgumentException in Guess Discussion ---------- [Form] replaced UnexpectedValueException by InvalidArgumentException in Guess BC break: yes this is a better fit because the error is a logic exception (that can be detected at compile time, i.e. when writing the code) instead of a runtime exception --------------------------------------------------------------------------- by bschussek at 2012-08-29T10:51:54Z :+1:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BC break: yes
this is a better fit because the error is a logic exception (that can be detected at compile time, i.e. when writing the code) instead of a runtime exception