8000 [SecurityBundle] Add missing removed config options to upgrade guide by W0rma · Pull Request #53522 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[SecurityBundle] Add missing removed config options to upgrade guide #53522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2024

Conversation

W0rma
Copy link
Contributor
@W0rma W0rma commented Jan 12, 2024
Q A
Branch? 7.0
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

Seems like some entries added in #50866 from got lost from the upgrade guide.

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.0".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 7.1 milestone Jan 12, 2024
@carsonbot carsonbot changed the title [SecurityBundle] [Bug] Add missing removed config options to upgrade guide [SecurityBundle] Add missing removed config options to upgrade guide Jan 12, 2024
@W0rma W0rma changed the base branch from 7.1 to 7.0 January 12, 2024 11:28
@xabbuh
Copy link
Member
xabbuh commented Jan 12, 2024

Do we need to update the changelog file of the SecurityBundle too? Looks like it would otherwise contain fewer entries.

@W0rma
Copy link
Contributor Author
W0rma commented Jan 12, 2024

Do we need to update the changelog file of the SecurityBundle too? Looks like it would otherwise contain fewer entries.

I have updated the changelog to use the same wording like the upgrade guide

@xabbuh xabbuh modified the milestones: 7.1, 7.0 Jan 13, 2024
@xabbuh
Copy link
Member
xabbuh commented Jan 13, 2024

Thank you @W0rma.

@xabbuh xabbuh merged commit 00c399c into symfony:7.0 Jan 13, 2024
@W0rma W0rma deleted the 7.0 branch January 13, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0