8000 [2.2] [FrameworkBundle] [Serializer] Loads the Serializer component as a service in the Framework Bundle by loalf · Pull Request #5347 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[2.2] [FrameworkBundle] [Serializer] Loads the Serializer component as a service in the Framework Bundle #5347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 26 commits into from
Closed

[2.2] [FrameworkBundle] [Serializer] Loads the Serializer component as a service in the Framework Bundle #5347

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
ca250b0
Adding the Serializer service to the Framework Bundle
humandb Aug 25, 2012
0b51471
Adding the Compiler Pass to add encoders and normalizers as tagged se…
humandb Aug 25, 2012
7b791fe
Fixing some issues with SerializerPass
humandb Aug 25, 2012
fb1685c
Now it sorts the encoders and normalizers depending on its priority
humandb Aug 25, 2012
881e9a6
Updated serializer.xml
humandb Aug 25, 2012
0278df8
Getting rid of the priorities
humandb Aug 26, 2012
e579aac
Added priority to the services according to the Symfony standards
humandb Sep 3, 2012
91812e2
Iterating through all the tags on the service
humandb Sep 3, 2012
4d6fdc0
Simplyfing the way to flatten the array acording to @stof comments
humandb Sep 3, 2012
5e24f74
Merge branch 'master' into serializer_in_dic
humandb Oct 14, 2012
d164806
Using camel case and typehinting the container
humandb Oct 18, 2012
b343488
Remove priority in encoders and normalizer as this is irrelevant
humandb Oct 18, 2012
4ef485a
Merge branch 'master' of git://github.com/symfony/symfony into serial…
humandb Oct 18, 20 8000 12
75d7ed9
Using canBeDisabled()
humandb Oct 18, 2012
8ccb530
Modifying CHANGELOG to reflect the new feature
humandb Oct 18, 2012
299c03e
Missing space after 'if'
humandb Oct 20, 2012
c6253ce
Adding the Serializer service to the Framework Bundle
humandb Aug 25, 2012
5fd4e90
Merge branch 'serializer_in_dic' of github.com:loalf/symfony into ser…
humandb Oct 29, 2012
1ddcba4
Merge branch 'serializer_in_dic' of github.com:loalf/symfony into ser…
humandb Oct 29, 2012
b46d4e9
Merge branch 'master' of git://github.com/symfony/symfony into serial…
humandb Nov 4, 2012
377aa31
Merge branch 'master' into serializer_in_dic
humandb Dec 16, 2012
731a05e
SerializerPass throws an exception if no encoders or normalizers are …
humandb Dec 16, 2012
627b69c
Adding functional testing for the SerializerPass class
humandb Dec 16, 2012
122ac5c
Merge branch 'serializer_in_dic' of github.com:loalf/symfony into ser…
humandb Dec 16, 2012
2fbd210
Merge branch 'master' into serializer_in_dic
humandb Jan 19, 2013
8cb0564
Fixed minor issues
humandb Jan 19, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Using canBeDisabled()
  • Loading branch information
@humandb
humandb committed Oct 18, 2012
commit 75d7ed95da2b471b56c97296176842fc5dfc01ec
9 changes: 2 additions & 7 deletions src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,13 +398,8 @@ private function addSerializerSection(ArrayNodeDefinition $rootNode)
->children()
->arrayNode('serializer')
->info('serializer configuration')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Serialized with a capital letter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the other "info" messages are lowercase,
https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L92
https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L110
https://github.com/symfony/symfony/blob/master/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L122
...

are you sure you want it to be capitalized?

->canBeUnset()
->treatNullLike(array('enabled' => true))
->treatTrueLike(array('enabled' => true))
->children()
->booleanNode('enabled')->defaultTrue()->end()
->end()
->end()
->canBeDisabled()
->end()
->end()
;
}
Expand Down
0