8000 pin nikic/php-parser to version 4 by xabbuh · Pull Request #53452 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

pin nikic/php-parser to version 4 #53452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Jan 7, 2024
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@carsonbot carsonbot added this to the 5.4 milestone Jan 7, 2024
@@ -134,6 +134,7 @@
"masterminds/html5": "^2.6",
"monolog/monolog": "^1.25.1|^2",
"nyholm/psr7": "^1.0",
"nikic/php-parser": "^4.13",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before, the classes were only present as PHPUnit installed them

@nicolas-grekas
Copy link
Member

Do we need this PR? Where do we reference php-parser in 5.4?

@xabbuh
Copy link
Member Author
xabbuh commented Jan 8, 2024

Nope, we indeed don't need this PR. I mistakenly assumed that the PhpAstExtractor was already present in 5.4 when preparing the changes for #53453. So this PR should have targeted 6.3 but is obsolet now that #53453 is based upon 6.3.

@xabbuh xabbuh closed this Jan 8, 2024
@xabbuh xabbuh deleted the pin-phpparser-4 branch January 8, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0