8000 [Mailer] [Azure] Fix resource name validation by t9toqwerty · Pull Request #53388 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mailer] [Azure] Fix resource name validation #53388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2024
Merged

[Mailer] [Azure] Fix resource name validation #53388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Symfony/Component/Mailer/Bridge/Azure/Tests/Transport/AzureApiTransportTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public function testTagAndMetadataHeaders()
public function testItDoesNotAllowToAddResourceNameWithDot()
{
$this->expectException(\Exception::class);
$this->expectExceptionMessage('Resource name cannot contain or end with a dot');
$this->expectExceptionMessage('Resource name must not end with a dot "."');

new AzureApiTransport('KEY', 'ACS_RESOURCE_NAME.');
}
Expand Down
4 changes: 2 additions & 2 deletions src/Symfony/Component/Mailer/Bridge/Azure/Transport/AzureApiTransport.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@ public function __construct(
EventDispatcherInterface $dispatcher = null,
LoggerInterface $logger = null,
) {
if (str_contains($resourceName, '.') || str_ends_with($resourceName, '.')) {
throw new \Exception('Resource name cannot contain or end with a dot.');
if (str_ends_with($resourceName, '.')) {
throw new \Exception('Resource name must not end with a dot ".".');
}

parent::__construct($client, $dispatcher, $logger);
Expand Down
0