[Form] don't allow users to force exceptions by submitting unexpected data #5337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
a test is missing for this. |
1 similar comment
|
@stof true, I will add one |
|
Added test. |
|
👍 Could you please squash the commits? |
… data this makes it more fault-tolerant by simply ignoring wrong stuff from hackers [Form] added test to ensure binding of wrong data is ignored
|
Done. |
fabpot
added a commit
that referenced
this pull request
Aug 29, 2012
Commits ------- eb2eba1 [Form] don't allow users to force exceptions by submitting unexpected data Discussion ---------- [Form] don't allow users to force exceptions by submitting unexpected data fix #5334 This makes it more fault-tolerant by simply ignoring wrong stuff from hackers. @bschussek: I didn't find any other UnexpectedTypeExceptions that could be invoked by simply submitting unexpected data. But I'm not 100% sure that there aren't any indirectly invokeable, e.g. in some listeners. --------------------------------------------------------------------------- by stof at 2012-08-24T22:34:52Z a test is missing for this. --------------------------------------------------------------------------- by Tobion at 2012-08-24T23:02:26Z @stof true, I will add one --------------------------------------------------------------------------- by Tobion at 2012-08-25T13:51:23Z Added test. --------------------------------------------------------------------------- by bschussek at 2012-08-29T11:07:37Z :+1: Could you please squash the commits? --------------------------------------------------------------------------- by Tobion at 2012-08-29T13:43:52Z Done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #5334
This makes it more fault-tolerant by simply ignoring wrong stuff from hackers.
@bschussek: I didn't find any other UnexpectedTypeExceptions that could be invoked by simply submitting unexpected data. But I'm not 100% sure that there aren't any indirectly invokeable, e.g. in some listeners.