8000 [Notifier] Use CPP by OskarStark · Pull Request #53234 · symfony/symfony · GitHub

[Notifier] Use CPP #53234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

nicolas-grekas merged 1 commit into symfony:7.1 from OskarStark:cpp-notifier-com

Jan 2, 2024

Contributor

OskarStark commented

Q	A
Branch?	7.1
Bug fix?	no
New feature?	no
Deprecations?	no
Issues	--
License	MIT

symfony deleted a comment from carsonbot

OskarStark marked this pull request as ready for review

December 27, 2023 12:59

carsonbot added Status: Needs Review Notifier labels

carsonbot added this to the 7.1 milestone

OskarStark commented

View reviewed changes

src/Symfony/Component/Notifier/Channel/BrowserChannel.php Outdated Show resolved Hide resolved

OskarStark commented

View reviewed changes

src/Symfony/Component/Notifier/Event/FailedMessageEvent.php Outdated Show resolved Hide resolved

OskarStark commented

View reviewed changes

src/Symfony/Component/Notifier/EventListener/SendFailedMessageToNotifierListener.php Show resolved Hide resolved

OskarStark commented

View reviewed changes

src/Symfony/Component/Notifier/Exception/IncompleteDsnException.php Outdated Show resolved Hide resolved

OskarStark commented

View reviewed changes

src/Symfony/Component/Notifier/Exception/TransportException.php Outdated Show resolved Hide resolved

OskarStark commented

View reviewed changes

src/Symfony/Component/Notifier/Message/ChatMessage.php Outdated Show resolved Hide resolved

OskarStark commented

View reviewed changes

src/Symfony/Component/Notifier/Message/EmailMessage.php Outdated Show resolved Hide resolved

OskarStark commented

View reviewed changes

src/Symfony/Component/Notifier/Message/PushMessage.php Outdated Show resolved Hide resolved

OskarStark commented

View reviewed changes

src/Symfony/Component/Notifier/Message/SentMessage.php Outdated Show resolved Hide resolved

OskarStark commented

View reviewed changes

src/Symfony/Component/Notifier/Message/SmsMessage.php Outdated Show resolved Hide resolved

OskarStark commented

View reviewed changes

src/Symfony/Component/Notifier/Messenger/MessageHandler.php Show resolved Hide resolved

OskarStark force-pushed the cpp-notifier-com branch from d340502 to b6acd08 Compare

December 27, 2023 13:03

OskarStark requested a review from derrabus

December 28, 2023 08:58

derrabus approved these changes

View reviewed changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

wouterj requested changes

View reviewed changes

src/Symfony/Component/Notifier/Notification/Notification.php Show resolved Hide resolved

carsonbot added Status: Needs Work and removed Status: Reviewed labels

derrabus reviewed

View reviewed changes

src/Symfony/Component/Notifier/Notification/Notification.php Outdated Show resolved Hide resolved

OskarStark commented

View reviewed changes

src/Symfony/Component/Notifier/Message/SmsMessage.php Show resolved Hide resolved

OskarStark force-pushed the cpp-notifier-com branch from 616b9f3 to b32199f Compare

December 29, 2023 20:10

Contributor Author

OskarStark commented

Rebased, comments addressed, fabbot unrelated

OskarStark requested a review from wouterj

December 29, 2023 20:13

carsonbot removed the Status: Needs Work label

carsonbot added the Status: Needs Review label

OskarStark requested review from fabpot and nicolas-grekas

December 29, 2023 20:13

nicolas-grekas reviewed

View reviewed changes

src/Symfony/Component/Notifier/Channel/ChannelPolicy.php Outdated Show resolved Hide resolved

OskarStark force-pushed the cpp-notifier-com branch from de66e0d to 40ec81d Compare

December 30, 2023 21:26

OskarStark added the Ready label


          [Notifier] Use CPP

dbe43a5

nicolas-grekas force-pushed the cpp-notifier-com branch from 40ec81d to dbe43a5 Compare

January 2, 2024 10:08

Member

nicolas-grekas commented

Thank you @OskarStark.

nicolas-grekas merged commit 6336d4e into symfony:7.1

OskarStark deleted the cpp-notifier-com branch

January 2, 2024 11:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Notifier Ready Status: Needs Review

0