Add minimum-stability (dev) in each component #5318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you really want to run the testsuite standalone, some dev requirements are missing (SecurityBundle needs the FrameworkBundle for its functional tests for instance). If you have some time to check the missing dev requirement, it would be great. |
|
Yes I already did that once. I'll try to fix more components later. On Wed, Aug 22, 2012 at 3:57 PM, Christophe Coevoet <
|
|
Well, I think most components should be good now (as some work has been done on them). But the bridges and bundles may need some work (bundles were not having any dev requirements until yesterday when @guilhermeblanco added some on FrameworkBundle) |
|
what about having for each READ-ONLY repo his own .travis.yml and travisci hook activated ? |
|
please, don't add more travis files. The main already tests everything, and that's all we need. |
|
@pborreli tests should not be different for subtree split repos as the code is the same and the tests are the same (except that more tests could be skipped because of missing deps). |
|
ok, i was just thinking about a way to be sure each component is usable individually but yeah that would require to relaunch each tests and add a bunch of travis files + hook |
|
@stof, @eriksencosta, @fabpot: Tests are different for Locale component, see #5235 |
|
@hason no. You also need to do it when running the tests of the Locale component as part of the full run. |
fabpot
added a commit
that referenced
this pull request
Aug 25, 2012
Commits ------- 933e821 Add minimum-stability (dev) in each component Discussion ---------- Add minimum-stability (dev) in each component This fixes the ability to run the test suite in each component if a `composer install` is needed. --------------------------------------------------------------------------- by stof at 2012-08-22T13:57:14Z If you really want to run the testsuite standalone, some dev requirements are missing (SecurityBundle needs the FrameworkBundle for its functional tests for instance). If you have some time to check the missing dev requirement, it would be great. Anyway, :+1: for this --------------------------------------------------------------------------- by willdurand at 2012-08-22T13:59:15Z Yes I already did that once. I'll try to fix more components later. On Wed, Aug 22, 2012 at 3:57 PM, Christophe Coevoet < notifications@github.com> wrote: > If you really want to run the testsuite standalone, some dev requirements > are missing (SecurityBundle needs the FrameworkBundle for its functional > tests for 8000 instance). If you have some time to check the missing dev > requirement, it would be great. > Anyway, [image: :+1:] for this > > — > Reply to this email directly or view it on GitHub<#5318 (comment)>. > > --------------------------------------------------------------------------- by stof at 2012-08-22T14:02:23Z Well, I think most components should be good now (as some work has been done on them). But the bridges and bundles may need some work (bundles were not having any dev requirements until yesterday when @guilhermeblanco added some on FrameworkBundle) --------------------------------------------------------------------------- by pborreli at 2012-08-22T14:14:00Z what about having for each READ-ONLY repo his own .travis.yml and travisci hook activated ? --------------------------------------------------------------------------- by fabpot at 2012-08-22T14:30:13Z please, don't add more travis files. The main already tests everything, and that's all we need. --------------------------------------------------------------------------- by stof at 2012-08-22T14:33:46Z @pborreli tests should not be different for subtree split repos as the code is the same and the tests are the same (except that more tests could be skipped because of missing deps). Note that for the bundles, it is likely to be different currently as I think some skip tests are missing (just like dev requirements are). But fixing this does not require enablign travis. --------------------------------------------------------------------------- by pborreli at 2012-08-22T14:42:30Z ok, i was just thinking about a way to be sure each component is usable individually but yeah that would require to relaunch each tests and add a bunch of travis files + hook --------------------------------------------------------------------------- by hason at 2012-08-24T13:12:04Z @stof, @eriksencosta, @fabpot: Tests are different for Locale component, see #5235 --------------------------------------------------------------------------- by stof at 2012-08-24T13:35:07Z @hason no. You also need to do it when running the tests of the Locale component as part of the full run.
fabpot
added a commit
to symfony/form
that referenced
this pull request
Nov 25, 2013
Commits ------- 933e821 Add minimum-stability (dev) in each component Discussion ---------- Add minimum-stability (dev) in each component This fixes the ability to run the test suite in each component if a `composer install` is needed. --------------------------------------------------------------------------- by stof at 2012-08-22T13:57:14Z If you really want to run the testsuite standalone, some dev requirements are missing (SecurityBundle needs the FrameworkBundle for its functional tests for instance). If you have some time to check the missing dev requirement, it would be great. Anyway, :+1: for this --------------------------------------------------------------------------- by willdurand at 2012-08-22T13:59:15Z Yes I already did that once. I'll try to fix more components later. On Wed, Aug 22, 2012 at 3:57 PM, Christophe Coevoet < notifications@github.com> wrote: > If you really want to run the testsuite standalone, some dev requirements > are missing (SecurityBundle needs the FrameworkBundle for its functional > tests for instance). If you have some time to check the missing dev > requirement, it would be great. > Anyway, [image: :+1:] for this > > — > Reply to this email directly or view it on GitHub<symfony/symfony#5318 (comment)>. > > --------------------------------------------------------------------------- by stof at 2012-08-22T14:02:23Z Well, I think most components should be good now (as some work has been done on them). But the bridges and bundles may need some work (bundles were not having any dev requirements until yesterday when @guilhermeblanco added some on FrameworkBundle) --------------------------------------------------------------------------- by pborreli at 2012-08-22T14:14:00Z what about having for each READ-ONLY repo his own .travis.yml and travisci hook activated ? --------------------------------------------------------------------------- by fabpot at 2012-08-22T14:30:13Z please, don't add more travis files. The main already tests everything, and that's all we need. --------------------------------------------------------------------------- by stof at 2012-08-22T14:33:46Z @pborreli tests should not be different for subtree split repos as the code is the same and the tests are the same (except that more tests could be skipped because of missing deps). Note that for the bundles, it is likely to be different currently as I think some skip tests are missing (just like dev requirements are). But fixing this does not require enablign travis. --------------------------------------------------------------------------- by pborreli at 2012-08-22T14:42:30Z ok, i was just thinking about a way to be sure each component is usable individually but yeah that would require to relaunch each tests and add a bunch of travis files + hook --------------------------------------------------------------------------- by hason at 2012-08-24T13:12:04Z @stof, @eriksencosta, @fabpot: Tests are different for Locale component, see #5235 --------------------------------------------------------------------------- by stof at 2012-08-24T13:35:07Z @hason no. You also need to do it when running the tests of the Locale component as part of the full run.
fabpot
added a commit
to symfony/framework-bundle
that referenced
this pull request
Nov 11, 2014
Commits ------- 933e821 Add minimum-stability (dev) in each component Discussion ---------- Add minimum-stability (dev) in each component This fixes the ability to run the test suite in each component if a `composer install` is needed. --------------------------------------------------------------------------- by stof at 2012-08-22T13:57:14Z If you really want to run the testsuite standalone, some dev requirements are missing (SecurityBundle needs the FrameworkBundle for its functional tests for instance). If you have some time to check the missing dev requirement, it would be great. Anyway, :+1: for this --------------------------------------------------------------------------- by willdurand at 2012-08-22T13:59:15Z Yes I already did that once. I'll try to fix more components later. On Wed, Aug 22, 2012 at 3:57 PM, Christophe Coevoet < notifications@github.com> wrote: > If you really want to run the testsuite standalone, some dev requirements > are missing (SecurityBundle needs the FrameworkBundle for its functional > tests for instance). If you have some time to check the missing dev > requirement, it would be great. > Anyway, [image: :+1:] for this > > — > Reply to this email directly or view it on GitHub<symfony/symfony#5318 (comment)>. > > --------------------------------------------------------------------------- by stof at 2012-08-22T14:02:23Z Well, I think most components should be good now (as some work has been done on them). But the bridges and bundles may need some work (bundles were not having any dev requirements until yesterday when @guilhermeblanco added some on FrameworkBundle) --------------------------------------------------------------------------- by pborreli at 2012-08-22T14:14:00Z what about having for each READ-ONLY repo his own .travis.yml and travisci hook activated ? --------------------------------------------------------------------------- by fabpot at 2012-08-22T14:30:13Z please, don't add more travis files. The main already tests everything, and that's all we need. --------------------------------------------------------------------------- by stof at 2012-08-22T14:33:46Z @pborreli tests should not be different for subtree split repos as the code is the same and the tests are the same (except that more tests could be skipped because of missing deps). Note that for the bundles, it is likely to be different currently as I think some skip tests are missing (just like dev requirements are). But fixing this does not require enablign travis. --------------------------------------------------------------------------- by pborreli at 2012-08-22T14:42:30Z ok, i was just thinking about a way to be sure each component is usable individually but yeah that would require to relaunch each tests and add a bunch of travis files + hook --------------------------------------------------------------------------- by hason at 2012-08-24T13:12:04Z @stof, @eriksencosta, @fabpot: Tests are different for Locale component, see #5235 --------------------------------------------------------------------------- by stof at 2012-08-24T13:35:07Z @hason no. You also need to do it when running the tests of the Locale component as part of the full run.
fago
pushed a commit
to fago/Validator
that referenced
this pull request
Apr 18, 2015
Commits ------- 933e821 Add minimum-stability (dev) in each component Discussion ---------- Add minimum-stability (dev) in each component This fixes the ability to run the test suite in each component if a `composer install` is needed. --------------------------------------------------------------------------- by stof at 2012-08-22T13:57:14Z If you really want to run the testsuite standalone, some dev requirements are missing (SecurityBundle needs the FrameworkBundle for its functional tests for instance). If you have some time to check the missing dev requirement, it would be great. Anyway, :+1: for this --------------------------------------------------------------------------- by willdurand at 2012-08-22T13:59:15Z Yes I already did that once. I'll try to fix more components later. On Wed, Aug 22, 2012 at 3:57 PM, Christophe Coevoet < notifications@github.com> wrote: > If you really want to run the testsuite standalone, some dev requirements > are missing (SecurityBundle needs the FrameworkBundle for its functional > tests for instance). If you have some time to check the missing dev > requirement, it would be great. > Anyway, [image: :+1:] for this > > — > Reply to this email directly or view it on GitHub<symfony/symfony#5318 (comment)>. > > --------------------------------------------------------------------------- by stof at 2012-08-22T14:02:23Z Well, I think most components should be good now (as some work has been done on them). But the bridges and bundles may need some work (bundles were not having any dev requirements until yesterday when @guilhermeblanco added some on FrameworkBundle) --------------------------------------------------------------------------- by pborreli at 2012-08-22T14:14:00Z what about having for each READ-ONLY repo his own .travis.yml and travisci hook activated ? --------------------------------------------------------------------------- by fabpot at 2012-08-22T14:30:13Z please, don't add more travis files. The main already tests everything, and that's all we need. --------------------------------------------------------------------------- by stof at 2012-08-22T14:33:46Z @pborreli tests should not be different for subtree split repos as the code is the same and the tests are the same (except that more tests could be skipped because of missing deps). Note that for the bundles, it is likely to be different currently as I think some skip tests are missing (just like dev requirements are). But fixing this does not require enablign travis. --------------------------------------------------------------------------- by pborreli at 2012-08-22T14:42:30Z ok, i was just thinking about a way to be sure each component is usable individually but yeah that would require to relaunch each tests and add a bunch of travis files + hook --------------------------------------------------------------------------- by hason at 2012-08-24T13:12:04Z @stof, @eriksencosta, @fabpot: Tests are different for Locale component, see #5235 --------------------------------------------------------------------------- by stof at 2012-08-24T13:35:07Z @hason no. You also need to do it when running the tests of the Locale component as part of the full run.
cmfcmf
pushed a commit
to cmfcmf/symfony-validator
that referenced
this pull request
Oct 10, 2020
Commits ------- 933e821 Add minimum-stability (dev) in each component Discussion ---------- Add minimum-stability (dev) in each component This fixes the ability to run the test suite in each component if a `composer install` is needed. --------------------------------------------------------------------------- by stof at 2012-08-22T13:57:14Z If you really want to run the testsuite standalone, some dev requirements are missing (SecurityBundle needs the FrameworkBundle for its functional tests for instance). If you have some time to check the missing dev requirement, it would be great. Anyway, :+1: for this --------------------------------------------------------------------------- by willdurand at 2012-08-22T13:59:15Z Yes I already did that once. I'll try to fix more components later. On Wed, Aug 22, 2012 at 3:57 PM, Christophe Coevoet < notifications@github.com> wrote: > If you really want to run the testsuite standalone, some dev requirements > are missing (SecurityBundle needs the FrameworkBundle for its functional > tests for instance). If you have some time to check the missing dev > requirement, it would be great. > Anyway, [image: :+1:] for this > > — > Reply to this email directly or view it on GitHub<symfony/symfony#5318 (comment)>. > > --------------------------------------------------------------------------- by stof at 2012-08-22T14:02:23Z Well, I think most components should be good now (as some work has been done on them). But the bridges and bundles may need some work (bundles were not having any dev requirements until yesterday when @guilhermeblanco added some on FrameworkBundle) --------------------------------------------------------------------------- by pborreli at 2012-08-22T14:14:00Z what about having for each READ-ONLY repo his own .travis.yml and travisci hook activated ? --------------------------------------------------------------------------- by fabpot at 2012-08-22T14:30:13Z please, don't add more travis files. The main already tests everything, and that's all we need. --------------------------------------------------------------------------- by stof at 2012-08-22T14:33:46Z @pborreli tests should not be different for subtree split repos as the code is the same and the tests are the same (except that more tests could be skipped because of missing deps). Note that for the bundles, it is likely to be different currently as I think some skip tests are missing (just like dev requirements are). But fixing this does not require enablign travis. --------------------------------------------------------------------------- by pborreli at 2012-08-22T14:42:30Z ok, i was just thinking about a way to be sure each component is usable individually but yeah that would require to relaunch each tests and add a bunch of travis files + hook --------------------------------------------------------------------------- by hason at 2012-08-24T13:12:04Z @stof, @eriksencosta, @fabpot: Tests are different for Locale component, see #5235 --------------------------------------------------------------------------- by stof at 2012-08-24T13:35:07Z @hason no. You also need to do it when running the tests of the Locale component as part of the full run.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the ability to run the test suite in each component if a
composer installis needed.