8000 [Notifier] Mention `postAt()` in the Slack bridge README by alexandre-daubois · Pull Request #53143 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Notifier] Mention postAt() in the Slack bridge README #53143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2023
Merged

[Notifier] Mention postAt() in the Slack bridge README #53143

merged 1 commit into from
Dec 19, 2023

Conversation

alexandre-daubois
Copy link
Member
Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Issues Fix symfony/symfony-docs#18958
License MIT

@alexandre-daubois alexandre-daubois request 8000 ed a review from OskarStark as a code owner December 19, 2023 14:34
@carsonbot carsonbot added this to the 6.4 milestone Dec 19, 2023
@Nyholm
Copy link
Member
Nyholm commented Dec 19, 2023

Thank you. I think we should mention this. But maybe do it in the Symfony-docs repo instead.

The readmes here are intentionally very very short and contains basic info only.

@alexandre-daubois
Copy link
Member Author

If I remember correctly, bridges' documentation are always contained in their own README, the doc doesn't mention available options of the different bridges. Maybe @OskarStark can confirm this as the code owner?

@Nyholm
Copy link
Member
Nyholm commented Dec 19, 2023

Yepp. You are correct. A quick look over the Notifier's Bridges show that Im wrong. Sorry about that.

Nyholm
Nyholm approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@alexandre-daubois
Copy link
Member Author

No worries 😄 I agree about the lines order, that's updated!

@fabpot
Copy link
Member
fabpot commented Dec 19, 2023

Thank you @alexandre-daubois.

@fabpot fabpot merged commit 024ad06 into symfony:6.4 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@Nyholm Nyholm Nyholm approved these changes

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Notifier Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alexandre-daubois @Nyholm @fabpot @carsonbot
0