8000 [Serializer] Keep stack trace for enum value denormalizer error by kylekatarnls · Pull Request #53081 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Keep stack trace for enum value denormalizer error #53081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2023
Merged

[Serializer] Keep stack trace for enum value denormalizer error #53081

merged 1 commit into from
Dec 18, 2023

Conversation

kylekatarnls
Copy link
Contributor
@kylekatarnls kylekatarnls commented Dec 14, 2023 •
edited
Loading
Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT

Simple previous: $exception added not to loose track of the error origin.

@carsonbot carsonbot added this to the 6.4 milestone Dec 14, 2023
mtarld
mtarld reviewed Dec 14, 2023
View reviewed changes
Copy link
Contributor
@mtarld mtarld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you target 5.4 instead?

@chalasr chalasr modified the milestones: 6.4, 5.4 Dec 14, 2023
@kylekatarnls kylekatarnls changed the base branch from 6.4 to 5.4 December 16, 2023 11:06
@kylekatarnls kylekatarnls requested a review from mtarld December 16, 2023 11:07
@nicolas-grekas
Copy link
Member

Thank you @kylekatarnls.

@nicolas-grekas nicolas-grekas merged commit 37708cb into symfony:5.4 Dec 18, 2023
This was referenced Dec 30, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtarld mtarld mtarld approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Bug Serializer Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@kylekatarnls @nicolas-grekas @mtarld @chalasr @carsonbot
0