8000 [FrameworkBundle] Add missing webhook parsers by alexandre-daubois · Pull Request #53004 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[FrameworkBundle] Add missing webhook parsers #53004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Dec 13, 2023
Merged

[FrameworkBundle] Add missing webhook parsers #53004

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b7a17ad
[FrameworkBundle] Fix webhook parser service removal and add notifier…
alexandre-daubois Dec 12, 2023
1aa17b8
bug #53007 [FrameworkBundle] Fix webhook parser service removal and a…
fabpot Dec 13, 2023
23f361c
Merge branch '6.3' into 6.4
fabpot Dec 13, 2023
b52b9e1
[FrameworkBundle] Add missing webhook parsers
alexandre-daubois Dec 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[FrameworkBundle] Fix webhook parser service removal and add notifier… 
… parser service removal
  • Loading branch information
@alexandre-daubois
alexandre-daubois committed Dec 12, 2023
commit b7a17ad5d0d0b941de6acf08ea9cbe7fe7e3fda4
14 changes: 13 additions & 1 deletion src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2632,7 +2632,7 @@ private function registerMailerConfiguration(array $config, ContainerBuilder $co
];

foreach ($webhookRequestParsers as $class => $service) {
$package = substr($service, \strlen('mailer.transport_factory.'));
$package = substr($service, \strlen('mailer.webhook.request_parser.'));

if (!ContainerBuilder::willBeAvailable(sprintf('symfony/%s-mailer', 'gmail' === $package ? 'google' : $package), $class, ['symfony/framework-bundle', 'symfony/mailer'])) {
$container->removeDefinition($service);
Expand Down Expand Up @@ -2839,6 +2839,18 @@ private function registerNotifierConfiguration(array $config, ContainerBuilder $

if ($webhookEnabled) {
$loader->load('notifier_webhook.php');

$webhookRequestParsers = [
NotifierBridge\Twilio\Webhook\TwilioRequestParser::class => 'notifier.webhook.request_parser.twilio',
];

foreach ($webhookRequestParsers as $class => $service) {
$package = substr($service, \strlen('notifier.webhook.request_parser.'));

if (!ContainerBuilder::willBeAvailable(sprintf('symfony/%s-notifier', $package), $class, ['symfony/framework-bundle', 'symfony/notifier'])) {
$container->removeDefinition($service);
}
}
}
}

Expand Down
0