8000 [MonologBridge] Fix context data and display extra data by louismariegaborit · Pull Request #52994 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[MonologBridge] Fix context data and display extra data #52994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub&r 8000 dquo;, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 29, 2024
Merged

[MonologBridge] Fix context data and display extra data #52994

merged 1 commit into from
Jan 29, 2024

Conversation

louismariegaborit
Copy link
Contributor
@louismariegaborit louismariegaborit commented Dec 11, 2023 •
edited
Loading
Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Issues ->
License MIT

Fix the compatibility with Monolog 3. In the PR #52222 we had the compatibility with Monolog 3 but context parameter is incorrect and extra parameter is missing.

No test can be added because testing this command is not possible at this time. Another PR (#53518) was opened to add test on this command.

@carsonbot carsonbot added this to the 6.3 milestone Dec 11, 2023
@carsonbot carsonbot changed the title Fix context data and display extra data [MonologBridge] Fix context data and display extra data Dec 11, 2023
@derrabus
Copy link
Member

No description, no test… I don't really know what to do with this change. 🤷🏻‍♂️

@louismariegaborit
Copy link
Contributor Author
louismariegaborit commented Dec 11, 2023 •
edited
Loading

No description, no test… I don't really know what to do with this change. 🤷🏻‍♂️

As I told in another PR, tests in this command are difficult.
This PR fix the display of context and extra data of log with Monolog 3.

I'm thinking about improving the command to integrate tests more easily.

@louismariegaborit
Copy link
Contributor Author

@derrabus I added a description and justify why we can't test this command in the PR summary.

@louismariegaborit
Copy link
Contributor Author

@derrabus PR could be reviewed with the additionals informations added in the PR description ?

nicolas-grekas
nicolas-grekas approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm just wondering: does the --filter option work with v3?

@louismariegaborit
Copy link
Contributor Author

LGTM. I'm just wondering: does the --filter option work with v3?

Thanks for the approve.
I tested on monolog/monolog:3.5.0 and the --filter option works.
What is your doubt ?

@nicolas-grekas
Copy link
Member

I was wondering about the call to $this->el->evaluate($filter, $record), whether $record was an array at this line. Looks like yes, thanks for confirming.

@nicolas-grekas
Copy link
Member

Thank you @louismariegaborit.

@nicolas-grekas nicolas-grekas merged commit 2fae7d5 into symfony:6.3 Jan 29, 2024
This was referenced Jan 30, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug MonologBridge Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

4 participants
@louismariegaborit @derrabus @nicolas-grekas @carsonbot
0