8000 [Serializer] Make sure Serializer::denormalize() shows what exception it throws by Nyholm · Pull Request #52992 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Make sure Serializer::denormalize() shows what exception it throws #52992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2023
Merged

[Serializer] Make sure Serializer::denormalize() shows what exception it throws #52992

merged 1 commit into from
Dec 13, 2023

Conversation

Nyholm
Copy link
Member
@Nyholm Nyholm commented Dec 11, 2023
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues no
License MIT

This was missing from #42502. We have no contract that explains that this exceptions should be thrown.

With this addition, we technically make this a "sometimes" feature of the Serializer class.

@Nyholm Nyholm requested a review from dunglas as a code owner December 11, 2023 11:43
@carsonbot carsonbot added this to the 5.4 milestone Dec 11, 2023
Nyholm added a commit to Nyholm/symfony that referenced this pull request Dec 11, 2023
@Nyholm
Move logic for PartialDenormalizationException back to Serializer
bbf3011 
See symfony#52992
@Nyholm Nyholm mentioned this pull request Dec 11, 2023
Open
@Nyholm Nyholm changed the title [Serializer] Make sure Serializer::denormalize() have show what exception it throws [Serializer] Make sure Serializer::denormalize() shows what exception it throws Dec 11, 2023
@fabpot
Copy link
Member
fabpot commented Dec 13, 2023

@fabpot fabpot merged commit 1ae24df into symfony:5.4 Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@mtarld mtarld mtarld approved these changes

@maxbeckers maxbeckers maxbeckers approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Serializer Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@Nyholm @fabpot @mtarld @maxbeckers @carsonbot
0

Thank you @Nyholm.