8000 [Serializer] Add ChainNormalizer and ChainDenormalizer by Nyholm · Pull Request #52900 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Add ChainNormalizer and ChainDenormalizer #52900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: 7.4
Choose a base branch
from
Open

[Serializer] Add ChainNormalizer and ChainDenormalizer #52900

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
5e56886
Add ChainNormalizer and ChainDenormalizer
Nyholm Oct 25, 2023
fc9c9ff
allow sf 6.4 on Mime and Messenger
Nyholm Jun 19, 2024
07c75ad
avoid updating composer.json in Messenger bridges
Nyholm Jun 19, 2024
70896a4
updates from review
Nyholm Jun 19, 2024
3ef1e1c
make TwigBridge support sf 6.4
Nyholm Jun 19, 2024
0e9704a
make error handler support sf 6.4
Nyholm Jun 19, 2024
1271e49
cs
Nyholm Jun 19, 2024
2ebb160
minors
Nyholm Jun 19, 2024
1d9d0c2
updating from feedback
Nyholm Jun 20, 2024
4f52388
introduce serializer.denormalizer tag
Nyholm Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
introduce serializer.denormalizer tag
  • Loading branch information
@Nyholm
Nyholm committed Jun 20, 2024
commit 4f523889f14195300dddac4891f9bda860d0429f
43 changes: 14 additions & 29 deletions src/Symfony/Component/Serializer/DependencyInjection/SerializerPass.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,16 @@ public function process(ContainerBuilder $container): void
return;
}

if (!$normalizers = $this->findAndSortTaggedServices('serializer.normalizer', $container)) {
throw new RuntimeException('You must tag at least one service as "serializer.normalizer" to use the "serializer" service.');
}

if (!$encoders = $this->findAndSortTaggedServices('serializer.encoder', $container)) {
throw new RuntimeException('You must tag at least one service as "serializer.encoder" to use the "serializer" service.');
}

$normalizers = $this->findAndSortTaggedServices('serializer.normalizer', $container);
$denormalizers = $this->findAndSortTaggedServices('serializer.denormalizer', $container);

if ($container->hasParameter('serializer.default_context')) {
$defaultContext = $container->getParameter('serializer.default_context');
foreach (array_merge($normalizers, $encoders) as $service) {
foreach (array_merge($normalizers, $denormalizers, $encoders) as $service) {
$definition = $container->getDefinition($service);
$definition->setBindings(['array $defaultContext' => new BoundArgument($defaultContext, false)] + $definition->getBindings());
}
Expand All @@ -64,42 +63,28 @@ public function process(ContainerBuilder $container): void
->setArguments([$normalizer, new Reference('serializer.data_collector')]);
}

foreach ($denormalizers as $i => $denormalizer ) {
$normalizers[$i] = $container->register('.debug.serializer.denormalizer.'.$denormalizer, TraceableNormalizer::class)
->setArguments([$denormalizer, new Reference('serializer.data_collector')]);
}

foreach ($encoders as $i => $encoder) {
$encoders[$i] = $container->register('.debug.serializer.encoder.'.$encoder, TraceableEncoder::class)
->setArguments([$encoder, new Reference('serializer.data_collector')]);
}
}

$denormalizers = [];
$trueNormalizers = [];
/** @var Reference|Definition $definition */
foreach ($normalizers as $definition) {
$reference = null;
if ($definition instanceof Reference) {
$reference = $definition;
$definition = $container->getDefinition($definition);
}

$class = $definition->getClass();
if (null === $class) {
continue;
}
$interfaces = class_implements($class);
if (isset($interfaces[NormalizerInterface::class])) {
$trueNormalizers[] = $reference ?? $definition;
}
if (isset($interfaces[DenormalizerInterface::class])) {
$denormalizers[] = $reference ?? $definition;
}
}

$serializerDefinition = $container->getDefinition('serializer');
$serializerDefinition->replaceArgument(1, $encoders);

// if FrameworkBundle 7.2 or above
if ($container->hasDefinition('serializer.normalizer') && $container->hasDefinition('serializer.denormalizer')) {
$container->getDefinition('serializer.normalizer')->replaceArgument(0, $trueNormalizers);
$container->getDefinition('serializer.normalizer')->replaceArgument(0, $normalizers);
$container->getDefinition('serializer.denormalizer')->replaceArgument(0, $denormalizers);
} else {
if (!$normalizers) {
throw new RuntimeException('You must tag at least one service as "serializer.normalizer" to use the "serializer" service.');
}
$serializerDefinition->replaceArgument(0, $normalizers);
}
}
Expand Down
Loading
0