[Form] Fixed error bubbling from DateTime widget - Issue #5270 #5280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travisbot shows something like this in it's log: So is it my PR ot Travis CI who fails ... ? I saw this error in some other PR's ... |
|
It's GitHub =) |
|
Bad GitHub :) |
| @@ -108,6 +108,8 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
| )); | |||
| } | |||
| } else { | |||
| $options['error_bubbling'] = true; | |||
There was a problem hiding this comment.
Please leave the options array unchanged and set this value after line 148 instead:
$dateOptions['input'] = $timeOptions['input'] = 'array';
$dateOptions['error_bubbling'] = $timeOptions['error_bubbling'] = true;
|
Could you please add a test to DateTimeTypeTest? |
|
Sure! |
|
👍 |
fabpot
added a commit
that referenced
this pull request
Aug 30, 2012
Commits ------- 58ebd1b [Form] Fixed error bubbling from DateTime widget - Issue #5270 8ea1607 Update src/Symfony/Component/Form/Extension/Core/Type/DateTimeType.php Discussion ---------- [Form] Fixed error bubbling from DateTime widget - Issue #5270 This is related to #5270 --------------------------------------------------------------------------- by mpiecko at 2012-08-16T19:37:45Z Travisbot shows something like this in it's log: [Composer\Downloader\TransportException] The "http://nodeload.github.com/phingofficial/phing/zipball/2.4.12" file could not be downloaded (HTTP/1.1 500 Internal Server Error) So is it my PR ot Travis CI who fails ... ? I saw this error in some other PR's ... --------------------------------------------------------------------------- by stloyd at 2012-08-16T20:40:39Z I 7B14 t's GitHub =) --------------------------------------------------------------------------- by mpiecko at 2012-08-17T09:36:31Z Bad GitHub :) --------------------------------------------------------------------------- by bschussek at 2012-08-17T11:21:39Z Could you please add a test to DateTimeTypeTest? --------------------------------------------------------------------------- by mpiecko at 2012-08-17T12:23:40Z Sure! --------------------------------------------------------------------------- by bschussek at 2012-08-30T08:20:08Z :+1:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to #5270