8000 [Form] Clean unused code by alamirault · Pull Request #52660 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

[Form] Clean unused code #52660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2023
Merged

[Form] Clean unused code #52660

merged 1 commit into from
Nov 23, 2023

Conversation

alamirault
Copy link
Contributor
@alamirault alamirault commented Nov 20, 2023 •
edited
Loading
Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #...
License MIT

Remove unused code

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1 for features / 5.4, 6.3, 6.4, or 7.0 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 7.1 milestone Nov 20, 2023
@alamirault alamirault force-pushed the feature/clean-unused-code-3 branch 2 times, most recently from f50bc32 to d6ab282 Compare November 20, 2023 18:50
@alamirault alamirault requested a review from yceruto November 20, 2023 20:12
@alamirault alamirault changed the base branch from 7.1 to 7.0 November 20, 2023 21:19
@alamirault alamirault requested a review from chalasr as a code owner November 20, 2023 21:19
@alamirault alamirault changed the base branch from 7.0 to 7.1 November 20, 2023 21:21
@fabpot fabpot force-pushed the feature/clean-unused-code-3 branch from 8f27290 to 1b4a246 Compare November 23, 2023 07:02
@fabpot
Copy link
Member
fabpot commented Nov 23, 2023

Thank you @alamirault.

@fabpot fabpot merged commit 8e0f304 into symfony:7.1 Nov 23, 2023
@alamirault alamirault deleted the feature/clean-unused-code-3 branch November 23, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@yceruto yceruto yceruto approved these changes

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@chalasr chalasr Awaiting requested review from chalasr

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
7.1
Development

Successfully merging this pull request may close these issues.
5 participants
@alamirault @carsonbot @fabpot @nicolas-grekas @yceruto
0