Undocumented BC break - choice field type template #5263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @bschussek |
| <option value="{{ choice.value }}"{% if _form_is_choice_selected(form, choice) %} selected="selected"{% endif %}> | ||
| {{ choice.label }} | ||
| {% for choice, label in choices %} | ||
| <option value="{{ choice }}"{% if choice is selectedchoice(form) %} selected="selected"{% endif %}> |
There was a problem hiding this comment.
should read {{ choice.value }} and selectedchoice(value)
|
Looks good apart from my comment. Thanks for fixing this! |
fabpot
added a commit
that referenced
this pull request
Aug 16, 2012
Commits ------- 9e3e589 Alter upgrade notes with changes to _form_is_choice_selected twig function Discussion ---------- Undocumented BC break - choice field type template The upgrade notes for the choice field template are out of date. They currently state: ``` The `choices` variable now contains `ChoiceView` objects with two getters, getValue() and getLabel(), to access the choice data. ``` However these methods do not exist. I assume this is the result of a rollback to maintain BC? In addition to this, the `_form_is_choice_selected` twig function has been removed and replaced with a filter called `selectedchoice`. This is an undocumented BC break. I have attached an update to the notes to reflect these changes. --------------------------------------------------------------------------- by fabpot at 2012-08-15T17:20:35Z ping @bschussek --------------------------------------------------------------------------- by bschussek at 2012-08-16T17:36:22Z Looks good apart from my comment. Thanks for fixing this!
|
We seem to have crossed our streams! It's gone into the doc as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade notes for the choice field template are out of date. They currently state:
However these methods do not exist. I assume this is the result of a rollback to maintain BC?
In addition to this, the
_form_is_choice_selectedtwig function has been removed and replaced with a filter calledselectedchoice. This is an undocumented BC break. I have attached an update to the notes to reflect these changes.