8000 [HttpClient] Revert "minor #52418 add native argument for the test server working directory" by nicolas-grekas · Pull Request #52602 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[HttpClient] Revert "minor #52418 add native argument for the test server working directory" #52602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2023
Merged

[HttpClient] Revert "minor #52418 add native argument for the test server working directory" #52602

merged 1 commit into from
Nov 15, 2023

Conversation

nicolas-grekas
Copy link
Member
Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

This reverts commit fa590af, reversing changes made to 907b683.

I completly forgot that we don't want to release a new major for contracts so the code in 7.0 must be in sync with the one in 6.4. /cc @xabbuh

@nicolas-grekas
Revert "minor symfony#52418 [HttpClient] add native argument for the …
1b61e92 
…test server working directory (xabbuh)"

This reverts commit fa590af, reversing
changes made to 907b683.
@carsonbot carsonbot added this to the 7.0 milestone Nov 15, 2023
@carsonbot carsonbot changed the title Revert "minor #52418 [HttpClient] add native argument for the test server working directory" [HttpClient] Revert "minor #52418 add native argument for the test server working directory" Nov 15, 2023
@fabpot
Copy link
Member
fabpot commented Nov 15, 2023

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 48793f9 into symfony:7.0 Nov 15, 2023
@nicolas-grekas nicolas-grekas deleted the contracts-fix branch November 15, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@stof stof stof approved these changes

Assignees
No one assigned
Labels
HttpClient Status: Reviewed
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@nicolas-grekas @fabpot @stof @carsonbot
0