[ErrorHandler] Do not use hyphens in exception message #52511
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
@javiereguiluz Do you like this change? |
|
@jkrzefski thanks for this proposal. The problem with exception messages is that they usually include super-long "words" (e.g. FQCN) that don't fit the available space. If we don't force breaking them, the result is that the message shows big blank spaces. Example of current exception design:
Same exception after this PR:
In any case, I agree with you that the extra So, instead of removing this CSS class, could you please change it to add the following? .break-long-words {
/* ... */
hyphenate-character: '';
}This way, it'd look like this:
Thanks! |
|
I've added a commit here to make this PR mergeable. Symfony 7.1 enters "feature freeze" period next Monday and I'd like to have this included in it. Thanks! |
|
Thank you @jkrzefski. |
This is just a minor cosmetic change in the error handler. Currently, error messages are shown with hyphenation if they exceed the available with. But in technical texts like exception messages, a hyphen could give the message a slightly different meaning. To reduce the risk for confusion, I removed the hyphenation.