8000 [Cache] Fix property types in PdoAdapter by HypeMC · Pull Request #52458 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Cache] Fix property types in PdoAdapter #52458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2023
Merged

[Cache] Fix property types in PdoAdapter #52458

merged 1 commit into from
Nov 5, 2023

Conversation

HypeMC
Copy link
Contributor
@HypeMC HypeMC commented Nov 5, 2023 •
edited by derrabus
Loading
Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

I've noticed this while working on #52457, there's no reason these properties should be mixed as far as I can tell.

@carsonbot carsonbot added this to the 6.3 milestone Nov 5, 2023
derrabus
derrabus approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member
@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 6.4

@derrabus derrabus changed the base branch from 6.3 to 6.4 November 5, 2023 17:45
@derrabus derrabus removed the Bug label Nov 5, 2023
@derrabus derrabus modified the milestones: 6.3, 6.4 Nov 5, 2023
@HypeMC HypeMC force-pushed the fix-property-types branch from 5afeffd to f306b74 Compare November 5, 2023 17:48
@HypeMC
Copy link
Contributor Author
HypeMC commented Nov 5, 2023

@derrabus Rebased with 6.4

@fabpot
Copy link
Member
fabpot commented Nov 5, 2023

Thank you @HypeMC.

@fabpot fabpot merged commit 5725df0 into symfony:6.4 Nov 5, 2023
@HypeMC HypeMC deleted the fix-property-types branch November 5, 2023 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Cache Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@HypeMC @fabpot @derrabus @carsonbot
0