8000 remove invalid group by xabbuh · Pull Request #52417 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

remove invalid group #52417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2023
Merged

remove invalid group #52417

merged 1 commit into from
Nov 2, 2023

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Nov 2, 2023
Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

@xabbuh xabbuh requested a review from yceruto as a code owner November 2, 2023 08:46
@carsonbot carsonbot added this to the 6.4 milestone Nov 2, 2023
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "5.4".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@xabbuh xabbuh changed the base branch from 6.4 to 5.4 November 2, 2023 08:47
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 5.4 Nov 2, 2023
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 756236a into symfony:5.4 Nov 2, 2023
@xabbuh xabbuh deleted the pr-39068 branch November 2, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @carsonbot @nicolas-grekas
0