8000 Update XmlEncoderTest.php by Youngemmy5956 · Pull Request #52414 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Update XmlEncoderTest.php #52414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update XmlEncoderTest.php #52414

wants to merge 1 commit into from

Conversation

Youngemmy5956
Copy link
@Youngemmy5956 Youngemmy5956 commented Nov 2, 2023 •
edited
Loading

added the test for xmlEncoder namespace i added a PR for review...

Q A
Branch? 6.4 for features / 5.4 or 6.3 for bug fixes
Bug fix? yes/no
New feature? yes/no
Deprecations? yes/no
Issues Fix #...
License MIT

@Youngemmy5956
Update XmlEncoderTest.php
d2e19ad 
added the test for xml namespace
@carsonbot carsonbot added this to the 6.4 milestone Nov 2, 2023
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.4 for features / 5.4 or 6.3 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@OskarStark
Copy link
Contributor

Related to #52401?

@Youngemmy5956
Copy link
Author

Yes

@OskarStark OskarStark mentioned this pull request Nov 3, 2023
Closed
@OskarStark
Copy link
Contributor

I cherry picked the test case to

@OskarStark OskarStark closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Deprecation Feature Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@Youngemmy5956 @carsonbot @OskarStark
0