8000 [Form] skip tests that do not work with ICU 71.1 by xabbuh · Pull Request #52245 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] skip tests that do not work with ICU 71.1 #52245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2023
+21 −0
Merged

[Form] skip tests that do not work with ICU 71.1 #52245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
skip tests that do not work with ICU 71.1
  • Loading branch information
@xabbuh
xabbuh committed Nov 30, 2023
commit 6e9d9abd2d85d08cf7ce011ba0ce2b1932fd785b
21 changes: 21 additions & 0 deletions src/Symfony/Component/Form/Tests/Extension/Core/Type/DateTypeTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use Symfony\Component\Form\ChoiceList\View\ChoiceView;
use Symfony\Component\Form\FormError;
use Symfony\Component\Form\FormInterface;
use Symfony\Component\Intl\Intl;
use Symfony\Component\Intl\Util\IntlTestHelper;
use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException;

Expand Down Expand Up @@ -90,6 +91,10 @@ public function testSubmitFromSingleTextDateTime()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -112,6 +117,10 @@ public function testSubmitFromSingleTextDateTimeImmutable()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -135,6 +144,10 @@ public function testSubmitFromSingleTextString()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de 8F83 _DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -157,6 +170,10 @@ public function testSubmitFromSingleTextTimestamp()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand All @@ -181,6 +198,10 @@ public function testSubmitFromSingleTextRaw()
// we test against "de_DE", so we need the full implementation
IntlTestHelper::requireFullIntl($this, false);

if ('71.1' === Intl::getIcuVersion()) {
$this->markTestSkipped('Skipping test due to a bug in ICU 71.1.');
}

\Locale::setDefault('de_DE');

$form = $this->factory->create(static::TESTED_TYPE, null, [
Expand Down
0