10000 [Notifier] [Brevo] Handle error responses without a message key by stof · Pull Request #52096 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Notifier] [Brevo] Handle error responses without a message key #52096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2023
Merged

[Notifier] [Brevo] Handle error responses without a message key #52096

merged 1 commit into from
Oct 17, 2023

Conversation

stof
Copy link
Member
@stof stof commented Oct 17, 2023
Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT

During their outage yesterday where the endpoint returned errors with status code 500, there was no message key in the json response.
This avoids a notice when the key does not exist. Instead, it uses the full response content, as done when the decoding fails.

This is the same change than #52095 but for the new Brevo bridge

@stof stof requested a review from OskarStark as a code owner October 17, 2023 08:44
@carsonbot carsonbot added this to the 6.4 milestone Oct 17, 2023
@stof stof force-pushed the brevo_error_response branch from a60d63f to 517ceae Compare October 17, 2023 08:46
@stof stof mentioned this pull request Oct 17, 2023
Merged
@carsonbot carsonbot changed the title Handle Brevo error responses without a message key [Notifier] Handle Brevo error responses without a message key Oct 17, 2023
@OskarStark OskarStark changed the title [Notifier] Handle Brevo error responses without a message key [Notifier][Brevo] Handle error responses without a message key Oct 17, 2023
@carsonbot carsonbot changed the title [Notifier][Brevo] Handle error responses without a message key [Notifier] [Brevo] Handle error responses without a message key Oct 17, 2023
@nicolas-grekas
Copy link
Member

Thank you @stof.

@nicolas-grekas nicolas-grekas merged commit f4b774f into symfony:6.4 Oct 17, 2023
@stof stof deleted the brevo_error_response branch October 17, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Bug Notifier Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@stof @nicolas-grekas @OskarStark @carsonbot
0