[HttpFoundation][Runtime] Add $flush parameter to Response::send()#52047
Merged
nicolas-grekas merged 1 commit intosymfony:6.4from Oct 18, 2023
Merged
Conversation
fancyweb
commented
Oct 13, 2023
src/Symfony/Component/Runtime/Runner/Symfony/HttpKernelRunner.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
previously approved these changes
Oct 13, 2023
Member
There was a problem hiding this comment.
Difficult to test, anyway, LGTM!
stof
reviewed
Oct 13, 2023
17a5728 to
be1e3bc
Compare
be1e3bc to
1cf9000
Compare
Member
There was a problem hiding this comment.
BTW @dunglas : does frankenphp provide an equivalent to fastcgi_finish_request()?
Member
|
Yes, it implements the function: php/frankenphp#69 |
1cf9000 to
8da05da
Compare
8da05da to
a3304cc
Compare
nicolas-grekas
approved these changes
Oct 18, 2023
Member
|
Thank you @fancyweb. |
This was referenced Oct 21, 2023
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by #51912 and #45205 subjects
Adds optional argument
$flushtoResponse::send(). If$flush === false, output buffers are not flushed/*_finish_request()and alike functions are not called.We leverage that in the Runtime component by not flushing the output buffers when debug mode is on in order to see exceptions thrown in listeners listening on the
TerminateEventand also to feel a more "real" processing time of things happening on terminate.