8000 [DoctrineBridge] Spread some PHP 8 love by derrabus · Pull Request #52044 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[DoctrineBridge] Spread some PHP 8 love #52044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 13, 2023
Merged

[DoctrineBridge] Spread some PHP 8 love #52044

merged 1 commit into from
Oct 13, 2023

Conversation

derrabus
Copy link
Member
Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Tickets N/A
License MIT

This PR modernizes the codebase of the DoctrineBridge with property types, CPP and readonly where we can do that without breaking backwards compatibility.

@carsonbot carsonbot added this to the 6.4 milestone Oct 13, 2023
@derrabus derrabus force-pushed the improvement/doctrine-bridge-php8 branch from 0c1a3f6 to ee85536 Compare October 13, 2023 12:18
nicolas-grekas
nicolas-grekas reviewed Oct 13, 2023
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I just have minor comments.

@derrabus derrabus force-pushed the improvement/doctrine-bridge-php8 branch from 2da4cee to 5aa9c47 Compare October 13, 2023 14:04
@nicolas-grekas
Copy link
Member

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 841374c into symfony:6.4 Oct 13, 2023
@derrabus derrabus deleted the improvement/doctrine-bridge-php8 branch October 13, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@stof stof stof left review comments

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
DoctrineBridge Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@derrabus @nicolas-grekas @stof @carsonbot
0