[Serializer] Add support for union collection value types in ArrayDenormalizer
#52018
+172
−82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8000
3e542ae to
cb066b3
Compare
|
Anyone with more background on Serializer would be willing to review this PR? (note that it should target 7.1 for now, maybe 7.2 if we can't make it since we're in feature freeze now). |
|
As #53160 has been merged, the |
|
Rebased onto 7.1 and description targeting 7.2. The new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently only the following array types combination is supported:
array<MyObject>|array<Another>. This results in arrays with only 1 type of objects.This PR aims to add support for arrays where values can be either of those, like union types:
array<MyObject|Another>.I've currently tested is successfully against the following types:
DateTimeInterface[]array<array<DateTimeInterface|DateInterval|string>>array<DateTimeInterface>|array<DateInterval>array<DateTimeInterface|DateInterval>array<DateTimeInterface|null>See also https://github.com/Jeroeny/reproduce/blob/mixedarray/src/Test.php