8000 Avoid calling TestCase::__construct() by derrabus · Pull Request #51878 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Avoid calling TestCase::__construct() #51878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 8, 2023
Merged

Avoid calling TestCase::__construct() #51878

merged 1 commit into from
Oct 8, 2023

Conversation

derrabus
Copy link
Member
@derrabus derrabus commented Oct 6, 2023
Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Part of #49069
License MIT

In PHPUnit 10, the constructor of the TestCase class has a parameter. Given that the constructor is internal anyway, I believe we should avoid calling it.

@derrabus derrabus force-pushed the improvement/testcase-construct branch from ae893ed to 2bc642f Compare October 6, 2023 18:35
@derrabus derrabus force-pushed the improvement/testcase-construct branch from 2bc642f to 410b3c0 Compare October 6, 2023 18:52
@derrabus derrabus force-pushed the improvement/testcase-construct branch from 410b3c0 to 0536876 Compare October 6, 2023 18:56
@fabpot
Copy link
Member
fabpot commented Oct 8, 2023

Thank you @derrabus.

@fabpot fabpot merged commit ca1eb17 into symfony:6.4 Oct 8, 2023
@derrabus derrabus deleted the improvement/testcase-construct branch October 8, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@derrabus @fabpot @OskarStark @carsonbot
0