Add "dev" keyword to symfony/symfony package #51811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's brilliant! |
stof
approved these changes
Oct 2, 2023
|
@nicolas-grekas can you do the same for the polyfill mono-repo then ? |
|
On it. Meanwhile I updated the PR for the contracts. |
This was referenced Oct 2, 2023
|
i appreciate the effort to keep symfony/symfony available as a package, but what for exactly? i assumed git clone+link would be the better practice for dev |
|
In short:
|
|
i was thinking then yes, signaling something to all existing installations could create some drama and/or unnessecary work. Perhaps it's not worth it. |
OskarStark
approved these changes
Oct 2, 2023
fabpot
approved these changes
Oct 2, 2023
|
Thank you @nicolas-grekas. |
fabpot
added a commit
to symfony/ux
that referenced
this pull request
Oct 2, 2023
This PR was merged into the 2.x branch. Discussion ---------- Add "dev" keyword to symfony/ux package | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Tickets | - | License | MIT Same as symfony/symfony#51811 Even if symfony/ux is not registered on packagist, I'm doing this for completeness and consistency among all our meta-repositories. Commits ------- c42a666 Add "dev" keyword to symfony/ux package
fabpot
added a commit
to symfony/polyfill
that referenced
this pull request
Oct 2, 2023
…kas) This PR was merged into the 1.x branch. Discussion ---------- Add "dev" keyword to symfony/polyfill package See symfony/symfony#51811 Commits ------- 0bc9478 Add "dev" keyword to symfony/polyfill package
This was referenced Oct 21, 2023
Merged
7CF3
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're periodically wondering about how we should tell people that they should require individual symfony packages instead of the meta repo. Marking the symfony/symfony package as "abandonned" on packagist is very close on a technical level, but semantically it's inaccurate.
I thought we might want to declare symfony/symfony as "for dev". WDYT?