8000 [Console][Form][FrameworkBundle][HttpKernel][PropertyInfo][Validator][WebProfilerBundle] Remove optional before required param by HypeMC · Pull Request #51778 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Console][Form][FrameworkBundle][HttpKernel][PropertyInfo][Validator][WebProfilerBundle] Remove optional before required param #51778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2023
Merged

[Console][Form][FrameworkBundle][HttpKernel][PropertyInfo][Validator][WebProfilerBundle] Remove optional before required param #51778

merged 1 commit into from
Sep 29, 2023

Conversation

HypeMC
Copy link
Member
@HypeMC HypeMC commented Sep 29, 2023 •
edited
Loading
Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT

I'm guessing this trick was used to make arguments nullable for PHP prior to 7.1, but since Symfony now requires at least PHP 8.1 it shouldn't be necessary any more. As far as I can tell there's no breaking change: https://3v4l.org/USkgi .

There are still four places that this is used, but I believe those to be intentional test cases:

symfony/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/autowiring_classes.php

Lines 179 to 184 in 3850658

class OptionalParameter
{
public function __construct(CollisionInterface $c = null, A $a, Foo $f = null)
{
}
}

symfony/src/Symfony/Component/DependencyInjection/Tests/Fixtures/includes/MultipleArgumentsOptionalScalarNotReallyOptional.php

Lines 8 to 13 in 3850658

class MultipleArgumentsOptionalScalarNotReallyOptional
{
public function __construct(A $a, $foo = 'default_val', Lille $lille)
{
}
}

symfony/src/Symfony/Component/VarDumper/Tests/Caster/ReflectionCasterTest.php

Lines 653 to 655 in 3850658

function reflectionParameterFixture(NotLoadableClass $arg1 = null, $arg2)
{
}

symfony/src/Symfony/Component/HttpKernel/Tests/DependencyInjection/RegisterControllerArgumentLocatorsPassTest.php

Lines 589 to 598 in 3850658

class NonExistentClassOptionalController
{
public function fooAction(NonExistentClass $nonExistent = null)
{
}
public function barAction(NonExistentClass $nonExistent = null, $bar)
{
}
}

@HypeMC
[FrameworkBundle][WebProfilerBundle][Console][Form][HttpKernel][Prope…
426c4e0 
…rtyInfo][Validator] Remove optional before required param
@carsonbot carsonbot added this to the 6.4 milestone Sep 29, 2023
@carsonbot carsonbot changed the title [FrameworkBundle][WebProfilerBundle][Console][Form][HttpKernel][PropertyInfo][Validator] Remove optional before required param [Console][Form][FrameworkBundle][HttpKernel][PropertyInfo][Validator][WebProfilerBundle] Remove optional before required param Sep 29, 2023
@nicolas-grekas
Copy link
Member

Thank you @HypeMC.

@nicolas-grekas nicolas-grekas merged commit 67e53fb into symfony:6.4 Sep 29, 2023
@HypeMC HypeMC deleted the remove-nullability-hack branch September 29, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto yceruto approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh xabbuh is a code owner

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Console Form FrameworkBundle HttpKernel PropertyInfo Status: Reviewed Validator WebProfilerBundle
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@HypeMC @nicolas-grekas @yceruto @carsonbot
0