StreamedResponse always sends a HTTP 1.1 response #5175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SERVER_PROTOCOL is "Name and revision of the information protocol via which the page was requested; i.e. 'HTTP/1.0'"
|
Seems to me that the Travis fails have absolutely nothing to do with my patch. |
fabpot
added a commit
that referenced
this pull request
Aug 4, 2012
Commits ------- b00ea41 StreamedResponse always sends a HTTP 1.1 response Discussion ---------- StreamedResponse always sends a HTTP 1.1 response SERVER_PROTOCOL is "Name and revision of the information protocol via which the page was requested; i.e. 'HTTP/1.0'". The condition was for 1.0 which is wrong. Earlier I filed #5173 --------------------------------------------------------------------------- by travisbot at 2012-08-03T18:33:45Z This pull request [fails](http://travis-ci.org/symfony/symfony/builds/2030496) (merged b00ea41 into be41ca3). --------------------------------------------------------------------------- by chx at 2012-08-03T18:36:58Z Seems to me that the Travis fails have absolutely nothing to do with my patch.
fabpot
added a commit
that referenced
this pull request
Aug 4, 2012
fabpot
added a commit
that referenced
this pull request
Aug 4, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SERVER_PROTOCOL is "Name and revision of the information protocol via which the page was requested; i.e. 'HTTP/1.0'". The condition was for 1.0 which is wrong.
Earlier I filed #5173