8000 Remove `setAccessible` reflection call in tests by alamirault · Pull Request #51727 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Remove setAccessible reflection call in tests #51727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2023
Merged

Remove setAccessible reflection call in tests #51727

merged 1 commit into from
Sep 24, 2023

Conversation

alamirault
Copy link
Contributor
Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

I checked all codebase, and found only this occurence when php >8.1 is required

Note: As of PHP 8.1.0, calling this method has no effect; all methods are invokable by default.

https://www.php.net/manual/en/reflectionmethod.setaccessible
https://www.php.net/manual/en/reflectionproperty.setaccessible.php

@carsonbot carsonbot added this to the 6.4 milestone Sep 23, 2023
@fabpot
Copy link
Member
fabpot commented Sep 24, 2023

Thank you @alamirault.

@fabpot fabpot merged commit fbf6f56 into symfony:6.4 Sep 24, 2023
@alamirault alamirault deleted the feature/remove-reflection-setAccessible branch September 24, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@derrabus derrabus derrabus approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alamirault @fabpot @derrabus @carsonbot
0