10000 [Mime] Add `TemplatedEmail::locale()` to set the locale for the email rendering by alexander-schranz · Pull Request #51690 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Mime] Add TemplatedEmail::locale() to set the locale for the email rendering #51690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2023
Merged

[Mime] Add TemplatedEmail::locale() to set the locale for the email rendering #51690

merged 1 commit into from
Oct 1, 2023

Conversation

alexander-schranz
Copy link
Contributor
@alexander-schranz alexander-schranz commented Sep 18, 2023 •
edited
Loading
Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

Add LocaleSwitcher to TemplatedEmail BodyRenderer. Currently it is not possible to render a twig template or a converter in a specific locale context.

It is common to send the email in the language of the receiver.

Usage

$email = (new TemplatedEmail())
    ->to('fabien@symfony.com')
    ->from('helene@symfony.com')
    ->subject('Hallo!')
    ->locale('de')
    ->textTemplate('email.txt.twig')
    ->htmlTemplate('email.html.twig')
    ->context($context)
;

nicolas-grekas
nicolas-grekas reviewed Sep 19, 2023
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please just add a line in the changelog of the bridge.

@nicolas-grekas nicolas-grekas changed the title [TwigBridge][Mime] Add LocaleSwitcher to TemplatedEmail BodyRenderer [TwigBridge][Mime] Add TemplatedEmail::locale() to set the locale for the email rendering Sep 19, 2023
@nicolas-grekas
Copy link
Member

ah, can you please check tests?

@nicolas-grekas
Copy link
Member

tests still :)

@nicolas-grekas nicolas-grekas added this to the 6.4 milestone Sep 25, 2023
@carsonbot carsonbot changed the title [TwigBridge][Mime] Add TemplatedEmail::locale() to set the locale for the email rendering [Mime] Add TemplatedEmail::locale() to set the locale for the email rendering Sep 25, 2023
@fabpot fabpot force-pushed the feature/local-switcher-templated-emails branch from 78e582e to d912384 Compare October 1, 2023 08:40
@fabpot
Copy link
Member
fabpot commented Oct 1, 2023

Thank you @alexander-schranz.

@fabpot fabpot merged commit decb566 int A881 o symfony:6.4 Oct 1, 2023
@fabpot fabpot mentioned this pull request Oct 1, 2023
Closed
This was referenced Oct 21, 2023
Merged
Merged
@mkrauser mkrauser mentioned this pull request Nov 24, 2023
Closed
@alexander-schranz alexander-schranz deleted the feature/local-switcher-templated-emails branch February 29, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Feature Mime Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@alexander-schranz @nicolas-grekas @fabpot @carsonbot
0