8000 [Security] OidcTokenHandler support JWKSet by louismariegaborit · Pull Request #51665 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Security] OidcTokenHandler support JWKSet #51665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 10 commits into from
Closed

[Security] OidcTokenHandler support JWKSet #51665

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3991c2f
Support JWKS json from url
louismariegaborit Sep 15, 2023
3b17a05
Fix for complete RS256 algorithm support
louismariegaborit Sep 15, 2023
1adc96d
Fix BC Break
louismariegaborit Sep 15, 2023
177642e
Update changelog
louismariegaborit Sep 15, 2023
dbf157c
Use HttpClient to get json from url
louismariegaborit Sep 15, 2023
3166188
OidcTokenHandlerTest : add test for JWKSet case
louismariegaborit Sep 15, 2023
615b64e
Fix psalm error
louismariegaborit Sep 15, 2023
aa228fc
Remove RSA algorithm support
louismariegaborit Jan 30, 2024
6e047ba
OidcTokenHandler first arg instance of AlgorithmManager
louismariegaborit Jan 31, 2024
4066312
Remove jwks_url parameter
louismariegaborit Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix psalm error
  • Loading branch information
@louismariegaborit
louismariegaborit committed Jan 30, 2024
commit 615b64eaa9e799b29fdd8139972b1ab4d963942f
12 changes: 5 additions & 7 deletions .../Bundle/SecurityBundle/DependencyInjection/Security/Factory/SignatureAlgorithmFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,27 +25,25 @@ final class SignatureAlgorithmFactory
{
public static function create(string $algorithm): AlgorithmInterface
{
$algorithmFqcn = Algorithm::class.'\\'.$algorithm;

switch ($algorithm) {
case 'ES256':
case 'ES384':
case 'ES512':
if (!class_exists(Algorithm::class.'\\'.$algorithm)) {
if (!class_exists($algorithmFqcn)) {
throw new \LogicException(sprintf('You cannot use the "%s" signature algorithm since "web-token/jwt-signature-algorithm-ecdsa" is not installed. Try running "composer require web-token/jwt-signature-algorithm-ecdsa".', $algorithm));
}

$algorithm = Algorithm::class.'\\'.$algorithm;
break;
case 'RS256':
if (!class_exists(Algorithm::class.'\\'.$algorithm)) {
if (!class_exists($algorithmFqcn)) {
throw new \LogicException(sprintf('You cannot use the "%s" signature algorithm since "web-token/jwt-signature-algorithm-rsa" is not installed. Try running "composer require web-token/jwt-signature-algorithm-rsa".', $algorithm));
}

$algorithm = Algorithm::class.'\\'.$algorithm;
break;
default:
throw new InvalidArgumentException(sprintf('Unsupported signature algorithm "%s". Only ES* and RS256 algorithms are supported. If you want to use another algorithm, create your TokenHandler as a service.', $algorithm));
}

return new $algorithm();
return new $algorithmFqcn();
}
}
0