8000 [TwigBridge] Remove duck typing from `AppVariable::getFlashes()` by derrabus · Pull Request #51619 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[TwigBridge] Remove duck typing from AppVariable::getFlashes() #51619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 11, 2023
Merged

[TwigBridge] Remove duck typing from AppVariable::getFlashes() #51619

merged 1 commit into from
Sep 11, 2023

Conversation

derrabus
Copy link
Member
Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Tickets Follows #50794
License MIT
Doc PR N/A

@carsonbot carsonbot added this to the 7.0 milestone Sep 10, 2023
@derrabus derrabus changed the title [TwigBridge] Remove duck typing from AppVariable::getFlashes() [TwigBridge] Remove duck typing from AppVariable::getFlashes() Sep 10, 2023
@derrabus
Copy link
Member Author

cc @Dirkhuethorst

Nyholm
Nyholm approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member
@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@chalasr
Copy link
Member
chalasr commented Sep 11, 2023

Thank you @derrabus.

@chalasr chalasr merged commit cc2a148 into symfony:7.0 Sep 11, 2023
@derrabus derrabus deleted the remove/get-session-duck-typing branch September 11, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nyholm Nyholm Nyholm approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Status: Reviewed TwigBridge
Projects
None yet
Milestone
7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@derrabus @chalasr @Nyholm @carsonbot
0