8000 [Notifier][Novu] Implement overrides by wouter-toppy · Pull Request #51577 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Notifier][Novu] Implement overrides #51577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 20, 2023
Merged

[Notifier][Novu] Implement overrides #51577

merged 1 commit into from
Oct 20, 2023

Conversation

@wouter-toppy
Copy link
Contributor
@wouter-toppy wouter-toppy commented Sep 6, 2023 •
edited by nicolas-grekas
Loading
Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #51576
License MIT

Implement Novu Overrides

@carsonbot carsonbot added this to the 6.4 milestone Sep 6, 2023
@wouter-toppy wouter-toppy changed the title Implement Novu overrides [RFC] Implement Novu overrides Sep 6, 2023
@wouter-toppy wouter-toppy force-pushed the feat-novu-overrides branch 2 times, most recently from a3a5e80 to ba31143 Compare September 6, 2023 10:15
stloyd
stloyd reviewed Sep 6, 2023
View reviewed changes
@stloyd
Copy link
Contributor
stloyd commented Sep 6, 2023

The title should be changed, it's not RFC but [Notifier]

stof
stof requested changes Sep 6, 2023
View reviewed changes
@carsonbot carsonbot changed the title [RFC] Implement Novu overrides Implement Novu overrides Sep 6, 2023
@carsonbot carsonbot changed the title Implement Novu overrides [Notifier] Implement Novu overrides Sep 6, 2023
@wouter-toppy wouter-toppy requested review from stloyd and stof September 6, 2023 11:02
OskarStark
OskarStark reviewed Sep 27, 2023
View reviewed changes
@fabpot fabpot modified the milestones: 6.4, 7.1 Oct 18, 2023
@OskarStark
Copy link
Contributor
OskarStark commented Oct 20, 2023

Can you please add a test case including overrides and not just an empty array? Thanks

@OskarStark OskarStark changed the title [Notifier] Implement Novu overrides [Notifier][Novu] Implement overrides Oct 20, 2023
@nicolas-grekas nicolas-grekas modified the milestones: 7.1, 6.4 Oct 20, 2023
@nicolas-grekas
Copy link
Member
nicolas-grekas commented Oct 20, 2023

Thank you @wouter-toppy.

@nicolas-grekas nicolas-grekas merged commit a19c534 into symfony:6.4 Oct 20, 2023
@nicolas-grekas nicolas-grekas mentioned this pull request Oct 20, 2023
Closed
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof Awaiting requested review from stof

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

1 more reviewer

@stloyd stloyd stloyd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature Notifier Status: Reviewed

Projects

None yet

Milestone

6.4

Development

Successfully merging this pull request may close these issues.

[Notifier] Implement Novu notifier overrides

8 participants

@wouter-toppy @stloyd @OskarStark @nicolas-grekas @stof @fabpot @derrabus @carsonbot
0