8000 [Serializer] Allow Context to target classes by mtarld · Pull Request #51476 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Serializer] Allow Context to target classes #51476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2023
Merged

[Serializer] Allow Context to target classes #51476

merged 1 commit into from
Sep 14, 2023

Conversation

mtarld
Copy link
Contributor
@mtarld mtarld commented Aug 24, 2023
Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #49450
License MIT
Doc PR TODO

Allow to target class with the Context attribute. The related context can be overridden by each property.

@mtarld mtarld requested a review from dunglas as a code owner August 24, 2023 14:40
@carsonbot carsonbot added this to the 6.4 milestone Aug 24, 2023
@mtarld mtarld force-pushed the feat/context-on-class branch from 95ab386 to c764fcf Compare August 24, 2023 14:42
@mtarld mtarld force-pushed the feat/context-on-class branch from c764fcf to dfcec29 Compare September 11, 2023 16:04
@nicolas-grekas nicolas-grekas changed the title [Serializer] Allow Context to target class [Serializer] Allow Context to target classes Sep 14, 2023
nicolas-grekas
nicolas-grekas approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member
@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed a few things, see https://github.com/symfony/symfony/compare/dfcec29218f5328284a2caa4460bf37e5277eb21..caaf0a6b71c3bcc8650e11a23bde6df4a6e4fb90

@nicolas-grekas
Copy link
Member

Thank you @mtarld.

@nicolas-grekas nicolas-grekas merged commit 972c442 into symfony:6.4 Sep 14, 2023
@nicolas-grekas nicolas-grekas mentioned this pull request Sep 14, 2023
Closed
@mtarld mtarld deleted the feat/context-on-class branch September 15, 2023 07:25
@Hanmac Hanmac mentioned this pull request Sep 15, 2023
Open
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Feature Serializer Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

[Serializer] Allow Context attribute to target class
5 participants
@mtarld @nicolas-grekas @dunglas @chalasr @carsonbot
0