8000 [VarExporter] Remove unused test files by alamirault · Pull Request #51406 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[VarExporter] Remove unused test files #51406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2023
Merged

[VarExporter] Remove unused test files #51406

merged 1 commit into from
Aug 17, 2023

Conversation

alamirault
Copy link
Contributor
Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

I searched unused test files with legacy in name in all source code

PR 3/3

@alamirault alamirault requested a review from chalasr as a code owner August 16, 2023 18:13
@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "6.4" but it seems your PR description refers to branch "6.3".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 6.4 milestone Aug 16, 2023
@alamirault alamirault changed the base branch from 6.4 to 6.3 August 16, 2023 18:14
@alamirault alamirault changed the title Feature/remove unused test files ve [VarExporter] Remove unused test files Aug 16, 2023
@alamirault alamirault force-pushed the feature/remove-unused-test-files-ve branch from 5fef3bd to 34086c6 Compare August 16, 2023 18:14
@nicolas-grekas nicolas-grekas modified the milestones: 6.4, 6.3 Aug 17, 2023
@nicolas-grekas
Copy link
Member

Thank you @alamirault.

Uh oh!

There was an error while loading. Please reload this page.
@nicolas-grekas nicolas-grekas merged commit 60ec641 into symfony:6.3 Aug 17, 2023
@alamirault alamirault deleted the feature/remove-unused-test-files-ve branch August 17, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@alamirault @carsonbot @nicolas-grekas
0