8000 [RemoteEvent][Webhook] Add Sendgrid support by smnandre · Pull Request #51305 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
/ symfony Public

[RemoteEvent][Webhook] Add Sendgrid support #51305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service 8000 and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[RemoteEvent][Webhook] Add Sendgrid support #51305

wants to merge 1 commit into from

Conversation

smnandre
Copy link
Member
@smnandre smnandre commented Aug 8, 2023
Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets -
License MIT
Doc PR -

Add support for Sendgrid webhook events

Test fixtures come from the documentation

@carsonbot carsonbot added this to the 6.4 milestone Aug 8, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.4 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@smnandre smnandre mentioned this pull request Aug 10, 2023
Merged
@WoutervanderLoopNL
Copy link
Contributor

I Already did the work ;-)

also with the feature of verifying the signature. and a option to reject requests without a signature

#50705

@smnandre
Copy link
Member Author
smnandre commented Aug 18, 2023 •
edited
Loading

I Already did the work ;-)

also with the feature of verifying the signature. and a option to reject requests without a signature

#50705

Omg.. I really don't know how i missed it.. i'm sorry for you (and a bit for the time i spent on it 🥲 )..

I'll close it obviously .. and i'll have a look at yours :)

I present you my sincere apologies @WoutervanderLoopNL

@smnandre
Copy link
Member Author

Closing in favor of #50705

@smnandre smnandre closed this Aug 18, 2023
@smnandre smnandre mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Feature RemoteEvent Status: Needs Review Webhook
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
3 participants
@smnandre @carsonbot @WoutervanderLoopNL
0